Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check null count too in sum aggregation #17964

Merged
merged 11 commits into from
Feb 13, 2025
Merged

Check null count too in sum aggregation #17964

merged 11 commits into from
Feb 13, 2025

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 9, 2025

Description

Closes #17963. We should also check the null count when doing a sum aggregation to match polars.

Also adds size and null_count directly to cudf.polars Column class.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Feb 9, 2025
@Matt711 Matt711 requested a review from a team as a code owner February 9, 2025 18:43
@Matt711 Matt711 requested review from wence- and mroeschke February 9, 2025 18:43
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Feb 9, 2025
@Matt711 Matt711 mentioned this pull request Feb 9, 2025
Closed
vyasr
vyasr approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mroeschke
mroeschke reviewed Feb 10, 2025
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review can be rolled into another PR

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 10, 2025

My review can be rolled into another PR

Thanks, I applied them in this PR :)

@Matt711
Copy link
Contributor Author

Matt711 commented Feb 11, 2025

/merge

@rapids-bot rapids-bot bot merged commit ee74e2d into rapidsai:branch-25.04 Feb 13, 2025
108 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@mroeschke mroeschke mroeschke approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
bug Something isn't working cudf.polars Issues specific to cudf.polars non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The sum of a fully missing column differs between polars[gpu] and polars.
3 participants
@Matt711 @vyasr @mroeschke