Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataFrame/Series.rank for int and null data in mode.pandas_compatible #17954

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Fix DataFrame/Series.rank for int and null data in mode.pandas_compatible #17954

merged 2 commits into from
Feb 8, 2025

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Feb 7, 2025 •
edited
Loading

Description

closes #17948

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Feb 7, 2025
@mroeschke mroeschke requested a review from a team as a code owner February 7, 2025 20:55
@mroeschke mroeschke requested review from wence- and bdice February 7, 2025 20:55
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 61e47bb into rapidsai:branch-25.04 Feb 8, 2025
117 of 119 checks passed
@mroeschke mroeschke deleted the bug/rank/int_nulls branch February 8, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series.rank differs from pandas in pandas.cudf
2 participants
@mroeschke @vyasr