Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pandas backend from cudf.pandas - ibis integration tests #17945

Open
wants to merge 3 commits into
base: branch-25.04
Choose a base branch
from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Feb 7, 2025

Description

ibis has removed their pandas backend in version 10.0.0. In their release notes,

pandas: The pandas backend is removed. Note that pandas DataFrames are STILL VALID INPUTS AND OUTPUTS and will remain so for the foreseeable future. Please use one of the other local backends like DuckDB, Polars, or DataFusion to perform operations directly on pandas DataFrames.

This PR removes the pandas backend from the integration tests. And asserts that the inputs and outputs to ibis APIs are proxy objects.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 7, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Feb 7, 2025
@Matt711 Matt711 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 7, 2025
@Matt711 Matt711 marked this pull request as ready for review February 7, 2025 01:16
@Matt711 Matt711 requested a review from a team as a code owner February 7, 2025 01:16
@Matt711 Matt711 added the DO NOT MERGE Hold off on merging; see PR for details label Feb 7, 2025
@Matt711
Copy link
Contributor Author

Matt711 commented Feb 7, 2025

Note: Let's wait on #17936, so we can ensure the integration tests pass before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant