Limit buffer size in reallocation policy in JSON reader #17940
+380
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shrshi
added
bug
shrshi
changed the title
|
/ok to test |
davidwendt
requested changes
Feb 11, 2025
Memcheck and racecheck pass without errors or hazards. |
davidwendt
reviewed
Feb 12, 2025
| @@ -605,7 +722,8 @@ device_span<char> ingest_raw_input(device_span<char> buffer, | |||
| thread_tasks.begin(), thread_tasks.end(), std::size_t{0}, [](std::size_t sum, auto& task) { | |||
| return sum + task.get(); | |||
| }); | |||
| CUDF_EXPECTS(bytes_read == total_bytes_to_read, "something's fishy"); | |||
| CUDF_EXPECTS(bytes_read == total_bytes_to_read, | |||
| "Incorrect number of bytes read by multithreaded reader"); | |||
There was a problem hiding this comment.
Oh wow. How did the fishy string get added without notice? 😄
davidwendt
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #17058
We can split the buffer at the last but one line and pass two buffers to the tokenizer, provided that the size of each of those buffers is less than 2GB. We only need to verify for the second buffer since the first one is guaranteed to be under the limit by the batching logic.
Checklist