Skip to content

Commit

Permalink
Enable sorting on column with nulls using query-planning (#15639)
Browse files Browse the repository at this point in the history
Related to #15027

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Charles Blackmon-Luca (https://github.com/charlesbluca)

URL: #15639
  • Loading branch information
rjzamora authored May 9, 2024
1 parent a4cd1d8 commit 69fe213
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python/dask_cudf/dask_cudf/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def categorical_dtype_cudf(categories=None, ordered=False):
@tolist_dispatch.register((cudf.Series, cudf.BaseIndex))
@_dask_cudf_nvtx_annotate
def tolist_cudf(obj):
return obj.to_arrow().to_pylist()
return obj.to_pandas().tolist()


@is_categorical_dtype_dispatch.register(
Expand Down
2 changes: 1 addition & 1 deletion python/dask_cudf/dask_cudf/tests/test_sort.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def test_sort_repartition():
dd.assert_eq(len(new_ddf), len(ddf))


@xfail_dask_expr("dask-expr code path fails with nulls")
@xfail_dask_expr("missing null support", lt_version="2024.5.1")
@pytest.mark.parametrize("na_position", ["first", "last"])
@pytest.mark.parametrize("ascending", [True, False])
@pytest.mark.parametrize("by", ["a", "b", ["a", "b"]])
Expand Down

0 comments on commit 69fe213

Please sign in to comment.