Skip to content

Commit

Permalink
Enhance mypy integration and type handling in workflow and task gener…
Browse files Browse the repository at this point in the history
…ation

- Added command to install mypy types in the GitHub Actions workflow for improved type checking.
- Refined import statements in `generate_task.py` by removing unnecessary imports and ensuring proper usage of `OrderedDict`.

These changes improve type safety and streamline the development workflow.
  • Loading branch information
ake2l committed Dec 24, 2024
1 parent f885f2f commit e584a25
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ jobs:
- name: Run mypy
run: |
. .venv/bin/activate
uv run mypy --install-types
uv run mypy datamimic_ce
shell: bash

Expand Down
3 changes: 2 additions & 1 deletion datamimic_ce/tasks/generate_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
import os
import shutil
import time
from collections import OrderedDict
from collections.abc import Callable
from contextlib import contextmanager
from pathlib import Path
from typing import Literal, OrderedDict
from typing import Literal

import dill # type: ignore
import xmltodict
Expand Down

0 comments on commit e584a25

Please sign in to comment.