Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dependencies; add extras feature #451

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

getzze
Copy link
Contributor

@getzze getzze commented Dec 4, 2024

Summary:

  • reorder pyproject.toml entries to make it easier to find the information.
  • add python 3.12 classifier
  • remove codecov, openpyxl and mpmath test dependencies as they are not used in tests.
  • add extras features to optionally install the mpmath dependency with pip install pingouin[extras].

On a side note, mpmath is an optional dependency as it is checked if it's installed in utils.py.
It's also checked if scikit-learn and statsmodels are installed in utils.py, whereas they are part of the hard dependencies. Meaning they should be installed, at least if installing with pip. These two dependencies could be moved to extras dependencies or the checks in utils.py could be removed.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (873eb4b) to head (e22ea7c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          19       19           
  Lines        3360     3360           
  Branches      492      492           
=======================================
  Hits         3311     3311           
  Misses         26       26           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@raphaelvallat raphaelvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you — this is great. I prefer to keep statsmodels and scikit-learn as hard dependencies. I'll merge the PR now.

@raphaelvallat raphaelvallat merged commit e98ad3f into raphaelvallat:main Dec 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants