Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated paste to be in line with POT; Using line search function from ot library #88

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Updated paste to be in line with POT; Using line search function from ot library #88

merged 6 commits into from
Nov 8, 2024

Conversation

anushka255
Copy link
Collaborator

No description provided.

@anushka255 anushka255 marked this pull request as draft November 7, 2024 19:32
@anushka255 anushka255 changed the title Checking what dependency changed since yesterday Updated paste to be in line with POT; Using line search function from ot library Nov 8, 2024
@anushka255 anushka255 marked this pull request as ready for review November 8, 2024 18:01
@vineetbansal
Copy link
Contributor

vineetbansal commented Nov 8, 2024 •
edited
Loading

  1. I think we forgot to pin POT to be >=0.9.5 since we're relying on the new signature.
  2. The docs workflow is failing (probably unpinning anndata has something to do with it).
  3. Could we have one commit where we don't remove the test for the function that you've eliminated here but just test the replaced library function instead?

vineetbansal
vineetbansal approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@vineetbansal vineetbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation! Thanks @anushka255

@anushka255 anushka255 merged commit 868c082 into main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vineetbansal vineetbansal vineetbansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anushka255 @vineetbansal