-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links and add GNU Bash as a hard dependency #3
base: master
Are you sure you want to change the base?
Conversation
A several links have been updated, a couple added, plus a tiny `vim` -> `vi`change: - `http` -> `https` for several websites - saves a redirect. - use the original URL for `less`, similarly to the `file` under "Optional" dependencies. - mention `bash` as a hard dependency - it's not available on every system, i.e. on `OpenBSD` it needs to be installed like any other package. - added a link to `exiftool`. - it doesn't seem like there's anything `vim`-specific in the keybinding so change it to `vi` - this is simply to avoid any confusion for people who are familiar with `vi` but don't use `vim`.
Don't like the "vi" change, no one knows vi but not vim so that's not a good enough motivation and it is in fact inspired by vim, no one in the team is old enough to have known vi before vim. Is bash a hard dependency? Most of ranger should be compatible with sh. |
Hi @toonn, Thanks for a prompt reply. The reason for
Regards, rjc |
You're right about vi, I agree with the change for consistency. Reading the vi manual will teach you basically nothing about ranger though.
|
@toonn, thanks for clarifying - this isn't immediately obvious while reading a bit lower on the same page:
If that is indeed the case - In terms of Also, on those systems, Regards, rjc |
Since it's only required for Maybe you're defining usage different from me. I'd expect anyone who spends significant time in vi to migrate to vim eventually. For one offs vi is fine but vim isn't name "VI Improved" for nothing. |
Here, I have to disagree with you regarding Then, after a very long time you start questioning things like: "Highlighting is a bit flaky at times. Do I really need it?", "Do I need that file browser in I spend most of my day in Anyway, I went off on a tangent :^). I fully agree with your last comment regarding |
If speed is what you care about you should worry more about what our puny brains can do and less about what extras some software implements that you don't "need." About the reasons for dependencies, do you feel like working on adding that? Probably best to do it in another PR and maybe there's a place for it in ranger's docs too. So if you remove the bash bullet from your original patch this one'd be good to go imo. |
@rjc, this PR seems to have fallen through the cracks. Are you interested in picking this back up? (I apologize for the side-tracking discussion, seems pointless in hindsight.) |
No worries, @toonn :^) I'll have another go in the next couple of days. |
A several links have been updated, a couple added, plus a tiny
vim
->vi
change:http
->https
for several websites - saves a redirect.less
, similarly to thefile
under "Optional" dependencies.bash
as a hard dependency - it's not available on every system, i.e. onOpenBSD
it needs to be installed like any other package.exiftool
.vim
-specific in the keybinding so change it tovi
- this is simply to avoid any confusion for people who are familiar withvi
but don't usevim
.