CI improvements #360
Merged
CI improvements #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 85.55% 85.55%
=======================================
Files 37 37
Lines 2084 2084
=======================================
Hits 1783 1783
Misses 301 301 ☔ View full report in Codecov by Sentry. |
Miepee
reviewed
Sep 9, 2024
| @@ -186,5 +186,3 @@ jobs: | |||
| - name: Publish 📦 to PyPI | |||
| if: ${{ startsWith(github.ref, 'refs/tags/') }} | |||
| uses: pypa/gh-action-pypi-publish@release/v1 | |||
| with: | |||
| password: ${{ secrets.pypi_password }} | |||
There was a problem hiding this comment.
if the password is not used anymore, then how is it publishing to pypi?
There was a problem hiding this comment.
There was a problem hiding this comment.
- why does testpy have the password then still
- where do we give the permission for ci to generate an identity token
There was a problem hiding this comment.
- Because test pypi uses a token that is for my entire account so I don't need to bother with per-project configs
- I seem to have not copied that part
Miepee
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.