Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TypedDict file for the json schema #279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Using the configuration classes

88bad8e
Select commit
Loading
Failed to load commit list.
Open

Create TypedDict file for the json schema #279

Using the configuration classes
88bad8e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 27, 2023 in 0s

85.85% (-1.86%) compared to 3898b42

View this Pull Request on Codecov

85.85% (-1.86%) compared to 3898b42

Details

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (3898b42) 87.71% compared to head (88bad8e) 85.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   87.71%   85.85%   -1.86%     
==========================================
  Files          35       35              
  Lines        1937     1987      +50     
==========================================
+ Hits         1699     1706       +7     
- Misses        238      281      +43     
Files Coverage Δ
src/open_dread_rando/misc_patches/exefs.py 100.00% <100.00%> (ø)
src/open_dread_rando/dread_patcher.py 92.26% <94.73%> (-0.56%) ⬇️
src/open_dread_rando/misc_patches/text_patches.py 96.00% <83.33%> (-1.96%) ⬇️
src/open_dread_rando/pickups/lua_editor.py 98.55% <88.88%> (-1.45%) ⬇️
src/open_dread_rando/pickups/map_icons.py 88.37% <75.00%> (-1.04%) ⬇️
src/open_dread_rando/cosmetic_patches/__init__.py 84.61% <71.42%> (-15.39%) ⬇️
...c/open_dread_rando/door_locks/custom_door_types.py 97.67% <75.00%> (-2.33%) ⬇️
...open_dread_rando/misc_patches/tilegroup_patcher.py 78.57% <75.00%> (-11.43%) ⬇️
.../open_dread_rando/specific_patches/game_patches.py 79.36% <71.42%> (-2.00%) ⬇️
src/open_dread_rando/specific_patches/objective.py 93.02% <71.42%> (-4.42%) ⬇️
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.