Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Feature_Water_Sens #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LoQue90
Copy link
Member

@LoQue90 LoQue90 commented Sep 3, 2024

rename Water Tank Sensor in total
-> FEATURE_WATERTANKSENSOR
-> waterTankFull/waterTankEmpty
-> kWaterTankEmpty
->..

So now Feature is more clearly represented in code and seperated more from hotWaterSwitch

if merge TO DO:

  • change PCB silkscreen and shematic to "WT_SENS"
  • change PCB Part in manual to right wording

@LoQue90 LoQue90 added the cleanup clean code label Sep 3, 2024
@LoQue90 LoQue90 requested review from kjyv and fiendie September 3, 2024 23:28
@LoQue90 LoQue90 self-assigned this Sep 3, 2024
@LoQue90 LoQue90 changed the title rename Feature_Water_Sense rename Feature_Water_Sens Sep 3, 2024
@LoQue90 LoQue90 force-pushed the rename-watersensor branch 2 times, most recently from 64dcfc2 to fe770da Compare September 3, 2024 23:36
@LoQue90
Copy link
Member Author

LoQue90 commented Oct 11, 2024

moving all water tank stuff out of main would be nice or? @fiendie @kjyv

rename water tank sensor in total
-> FEATURE_WATERTANKSENSOR
-> waterTankFull/waterTankEmpty
-> kWaterTankEmpty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup clean code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants