Bugfix: Inonsistent Brew & Steam switch behaviours #413 #414 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genkigenki
changed the title
genkigenki
changed the title
fix display template and clean up
First draft of a CONTRIBUTING file with style guidelines
README.md: Included that brew switch can be reconfigured to a push button
genkigenki
added a commit
to genkigenki/clevercoffee
that referenced
this pull request
Dec 18, 2023
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Trigger time measurement & print to debug if VERBOSE. Debounce times to 20ms. Added variable brewSwitchLongPress to brewscale.ini, set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastButtonStateBrewTrigger
genkigenki
added a commit
to genkigenki/clevercoffee
that referenced
this pull request
Dec 18, 2023
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Trigger time measurement & print to debug if VERBOSE. Debounce times to 20ms. Added variable brewSwitchLongPress to brewscale.ini, set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastButtonStateBrewTrigger
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Dec 26, 2023
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Dec 26, 2023
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Dec 26, 2023
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Jan 4, 2024
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Jan 4, 2024
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Jan 8, 2024
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
LoQue90
pushed a commit
to LoQue90/clevercoffee
that referenced
this pull request
Jan 8, 2024
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
fiendie
pushed a commit
that referenced
this pull request
Jan 8, 2024
Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
genkigenki
added a commit
to genkigenki/clevercoffee
that referenced
this pull request
Jan 20, 2024
…ancilio-pid#414 Debounce on Brew trigger. Steam trigger code duplication disabled debounce. Debounce times to 20ms. Added variable brewSwitchLongPress and set to 500ms. Rename BREWSWITCHDELAY to SHOTTIMERDISPLAYDELAY, adapt comments to fit to functionality. Rename brewSwitchLongPress -> brewTriggerLongPress and lastButtonStateBrew -> lastStateBrewTrigger clean brewvoid rename a lot of variables to naming scheme rename var steam and power trigger more rename variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brew button was not debounced, leading to erratic behaviour if your switches are not perfect.
5s delay removed, as its not needed (was likely introduced due to erratic behaviour due to bouncing switches)
Steam button configured as push button was twice checked and once not debounced. Removed check in main.cpp. Also migrated missing code to switchvoid file from main to ensure behaviour for switch users stays same.