Water Sensor shown on display with icons #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiendie
requested changes
Dec 3, 2023
fiendie
requested changes
Dec 5, 2023
genkigenki
force-pushed
the
MakuroWater
branch
2 times, most recently
from
717192d
to
0bc64b8
Compare
fiendie
previously approved these changes
Dec 11, 2023
LoQue90
reviewed
Dec 14, 2023
* Remove unused function call from Displaytemplateminimal.h * Fix indentation and spacing * Add missing call of checkSteamON() * Remove unnecessary semicolons from display.h * Remove unnecessary comments
…eads, center icon and remove text
genkigenki
force-pushed
the
MakuroWater
branch
from
0bc64b8
to
7b29809
Compare
fiendie
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Water Sensor, "water empty" icon shown in top right, on each display mode
In case the water sensor is not configured, water_full=true always, so no icon will ever be shown.