Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ABP2 pressure sensor support #396

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

stefan23
Copy link

need to add to userConfig.h:
#define PRESSURE_VERBOSE 1 // if you want extra debug output
#define PRESSURESENSOR 2 // 0 = no pressure sensor connected, 1 = pressure sensor connected, 2 = ABP2 pressure sensor connected

@LoQue90
Copy link
Member

LoQue90 commented Dec 24, 2023

could you add the changes for the userConfig_sample.h in this PR, so the build actions won´t fail? :)
i tryed this yesterday, was working good (onyl checked mqtt output and serial)!

@stefan23
Copy link
Author

stefan23 commented Jan 3, 2024

could you add the changes for the userConfig_sample.h in this PR, so the build actions won´t fail? :) i tryed this yesterday, was working good (onyl checked mqtt output and serial)!

Sure. Sorry for the delay, I was more or less offline during Christmas break. Will the build actions understand it and try to build with #define PRESSURESENSOR 2?
And furthermore, I am still not fully familiar with GitHub and it seems that my subsequent commits after I filed the PR have been included into it. They are not fully completed yet and some code changes need adding the check for PRESSURESENSOR.

@LoQue90
Copy link
Member

LoQue90 commented Jan 3, 2024

No they will build with the plain userconfig_sample.
But right now the build actions can't test anything because with those missing pressure macros it can't build.
We should add more example config that will be build and checked.

Stefan Jung and others added 2 commits January 14, 2024 16:44
* Remove old analog pressure sensor code
* Move all code to pressure.h because the implementation file doesn't have a constructor
* Use existing VERBOSE flag for serial output
src/pressure.cpp Outdated Show resolved Hide resolved
@LoQue90 LoQue90 merged commit ee5410b into rancilio-pid:master Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants