Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brew timer during coldstart #376

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

kjyv
Copy link
Collaborator

@kjyv kjyv commented Oct 1, 2023

Fixes #366 by not running brew detection while heating up

@LoQue90
Copy link
Member

LoQue90 commented Oct 1, 2023

i allready reworked the steamswitch to be implemented like the brew switch.
Off/Switch/trigger
maybe you want to add this here
https://github.com/LoQue90/clevercoffee/tree/rework-steamswitch

@kjyv
Copy link
Collaborator Author

kjyv commented Oct 1, 2023

i allready reworked the steamswitch to be implemented like the brew switch. Off/Switch/trigger maybe you want to add this here https://github.com/LoQue90/clevercoffee/tree/rework-steamswitch

Nice, why isn't it a PR or merged already? ;)

@LoQue90
Copy link
Member

LoQue90 commented Oct 1, 2023

i allready reworked the steamswitch to be implemented like the brew switch. Off/Switch/trigger maybe you want to add this here https://github.com/LoQue90/clevercoffee/tree/rework-steamswitch

Nice, why isn't it a PR or merged already? ;)

did this while trying to bring the switch config to the website, but never finished it.
PR is on the way :)

@kjyv kjyv force-pushed the fix-brew-timer-during-coldstart branch from 98fd7db to 5b1dfa8 Compare October 3, 2023 17:49
@kjyv
Copy link
Collaborator Author

kjyv commented Oct 3, 2023

Ok, I merged your PR and this is based on your changes now. I didn't test it yet but should behave the same

@kjyv
Copy link
Collaborator Author

kjyv commented Oct 4, 2023

Ok, also tested it and still works well

@LoQue90
Copy link
Member

LoQue90 commented Oct 9, 2023

runs fine on my silvia

@LoQue90 LoQue90 merged commit 77f3c9a into rancilio-pid:master Dec 5, 2023
1 check passed
@kjyv kjyv deleted the fix-brew-timer-during-coldstart branch February 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coldstart interrupted from shot
3 participants