[release/v0.5] Prevent deletion of local cluster (#551)
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent deletion of `local` cluster It prevents deletion of both clusters.provisioning.cattle.io and cluster.management.cattle.io of the name `local`. Signed-off-by: Dharmit Shah <[email protected]> * Prevent deletion of `local` and `fleet-local` namespaces Signed-off-by: Dharmit Shah <[email protected]> * Parameter type grouping Signed-off-by: Dharmit Shah <[email protected]> --------- Signed-off-by: Dharmit Shah <[email protected]>
|
The unit test is failing because of the change introduced here. Discussing this with the team to figure a way ahead. |
The unit test change made in rancher@ac777f7#diff-27385eb9113237f9a5e650a62ae7a3cc56fedf10b78449f890670221804d344fR172-R174 caused the unit tests to fail. This commit backports the `if` condition from that commit.
crobby
approved these changes
Feb 5, 2025
snasovich
approved these changes
Feb 5, 2025
This was referenced Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent deletion of
localclusterIt prevents deletion of both clusters.provisioning.cattle.io and cluster.management.cattle.io of the name
local.Prevent deletion of
localandfleet-localnamespacesParameter type grouping
Issue: rancher/rancher#48305
Problem
Solution
CheckList