Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional e2e fixes #958

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Dec 31, 2024

This PR is to fix the e2e workflow and bring some improvements.

The turtles-e2e image is now only built once as pre-requisite job. I kept the v0.0.1 tag because changing this has further implications down the line and should be propagated better, for example to the helm chart values and the test/e2e/config/operator.yaml file.

The image is also now deleted correctly always, when all parallel jobs end.
See: https://github.com/rancher/turtles/pkgs/container/turtles-e2e

Sample run: https://github.com/rancher/turtles/actions/runs/12595032471

@anmazzotti anmazzotti marked this pull request as ready for review December 31, 2024 12:09
@anmazzotti anmazzotti requested a review from a team as a code owner December 31, 2024 12:09
@anmazzotti anmazzotti enabled auto-merge December 31, 2024 12:28
salasberryfin
salasberryfin previously approved these changes Dec 31, 2024
@anmazzotti anmazzotti disabled auto-merge December 31, 2024 14:20
@anmazzotti anmazzotti marked this pull request as draft December 31, 2024 14:20
@anmazzotti anmazzotti force-pushed the additional_e2e_fixes branch 11 times, most recently from 59e912e to f5a9460 Compare January 3, 2025 08:29
Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti force-pushed the additional_e2e_fixes branch from f5a9460 to 2942cf2 Compare January 3, 2025 08:37
@anmazzotti anmazzotti self-assigned this Jan 3, 2025
@anmazzotti anmazzotti marked this pull request as ready for review January 3, 2025 09:35
@kkaempf kkaempf added this to the January 2025 milestone Jan 3, 2025
@furkatgofurov7
Copy link
Contributor

I was checking https://github.com/rancher/turtles/pkgs/container/turtles-e2e and looks like image cleaning failed. Is it unrelated to this PR and can be ignored?

@anmazzotti
Copy link
Contributor Author

anmazzotti commented Jan 3, 2025

@furkatgofurov7 the cleanup fails because the package has only one version left. GitHub is preventing deletion of that version (even though the error message is super misleading).

Next time it will run the current v0.0.1 version will become untagged, and all follow up cleanups will succeed.
The drawback is that we will have this trailing untagged image as a leftover.

I can experiment further and see if we can delete the entire package, instead of the specific version only, but possibly outside this PR.

I tried to repeat a run: https://github.com/rancher/turtles/actions/runs/12599916400
This time the clean image job succeeds, however one of these tests seem flaky.

@anmazzotti anmazzotti enabled auto-merge January 6, 2025 17:01
@anmazzotti anmazzotti merged commit ec4f72e into rancher:main Jan 6, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants