Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enabling Clusterclass operations via helm install #1074

Conversation

salasberryfin
Copy link
Contributor

What this PR does / why we need it:

ClusterClass operations controller is available under exp folder but is (as of today) only executed when using Tilt. This PR brings support to enable it via helm install. These are the changes that are applied:

  • Build clusterclass-operations image from Dockerfile.
  • Add clusterclass-operations to general make actions: test, build-chart.
  • New features.clusterclass-operations field in Helm chart values.
  • Make script for generating exp CRDs agnostic so it can be used for both day2 and clusterclass.
  • Update development environment to deploy controller by default.

Which issue(s) this PR fixes:
Fixes #1066

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Carlos Salas <[email protected]>
Signed-off-by: Carlos Salas <[email protected]>
@salasberryfin salasberryfin requested a review from a team as a code owner February 5, 2025 16:41
@salasberryfin salasberryfin changed the title Support enablingg Clusterclass operations via helm install Support enabling Clusterclass operations via helm install Feb 6, 2025
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might have a conflict with #1073

@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) February 6, 2025 21:08
@furkatgofurov7 furkatgofurov7 merged commit b8394d1 into rancher:main Feb 6, 2025
14 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ClusterClass Operations] Basic rebase operation behind feature value
3 participants