-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend docs on clusterclass #163
extend docs on clusterclass #163
Conversation
cb5fd10
to
70ebf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small nits/suggestions, otherwise looks great, thanks!
apiVersion: turtles-capi.cattle.io/v1alpha1 | ||
kind: CAPIProvider | ||
metadata: | ||
name: kubeadm-control-plane | ||
namespace: capi-kubeadm-control-plane-system | ||
spec: | ||
name: kubeadm | ||
type: controlPlane | ||
configSecret: | ||
name: variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t need kubeadm
provider to deploy AKS cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct. This is needed to satisfy CAPI's webhooks that require a valid reference to a bootstrap object. Whatever is referenced here won't be used at any point in provisioning. For now I think I'll change it to RKE2, as it will simplify things for Turtles' users but I'll be taking a look at how this is implemented upstream and whether we can remove this hard requirement because this will happen with any other provider that supports managed clusters (namely aws, gcp).
apiVersion: turtles-capi.cattle.io/v1alpha1 | ||
kind: CAPIProvider | ||
metadata: | ||
name: azure | ||
namespace: capz-system | ||
spec: | ||
type: infrastructure | ||
name: azure | ||
credentials: | ||
rancherCloudCredential: <rancher-credential-name> # Rancher credentials secret for Azure | ||
configSecret: | ||
name: azure-variables | ||
variables: | ||
CLUSTER_TOPOLOGY: "true" | ||
EXP_CLUSTER_RESOURCE_SET: "true" | ||
EXP_MACHINE_POOL: "true" | ||
EXP_AKS_RESOURCE_HEALTH: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CAPIProvider should look like
apiVersion: turtles-capi.cattle.io/v1alpha1
kind: CAPIProvider
metadata:
name: azure
namespace: capz-system
spec:
type: infrastructure
in order to work. All other fields are not required in AKS case.
70ebf35
to
14d6b72
Compare
Signed-off-by: Carlos Salas <[email protected]>
14d6b72
to
f3ac6db
Compare
Description
This PR introduces a new section on cluster classes.
Certified Providers
table with basic information on ClusterClass support for each of the certified providers.I think we should probably re-think the other cluster class guide (deploying via Fleet) and align both. I'd probably do this in a separate PR.
Fixes #161