Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing CVE Pages Across Docs/i18n Versions #1589

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

sunilarjun
Copy link
Contributor

Syncing v2.10 CVE page as some CVE's were missing from previous updates.

Copy link
Contributor

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The starting pipe character is missing from the start of each row.

Note: also seems to be the case for original PR that's referenced.

@sunilarjun sunilarjun marked this pull request as draft December 20, 2024 20:27
@sunilarjun sunilarjun marked this pull request as ready for review December 23, 2024 19:13
@sunilarjun
Copy link
Contributor Author

The starting pipe character is missing from the start of each row.

Note: also seems to be the case for original PR that's referenced.

@btat Thanks for catching Billy! I've pushed a fix to address the missing pipe character between versions, and also realized that the i18n CVE versions were out of sync for a few updates so added those in with this PR as well. Let me know if anything needs to be adjusted, thank you!

@sunilarjun sunilarjun changed the title Syncing v2.10 CVE Page Syncing CVE Pages Across Docs/i18n Versions Dec 23, 2024
btat
btat previously approved these changes Dec 23, 2024
Copy link
Contributor

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunilarjun LGTM. One small nit is that 22030 could have its translation preserved, but adding an approval since it's not a blocker.

@sunilarjun
Copy link
Contributor Author

@btat Thanks for catching that! Added the translated version back in and added back an incorrectly removed CVE from v2.7, please let me know if anything else needs editing.

@sunilarjun sunilarjun requested a review from btat December 27, 2024 21:25
@sunilarjun sunilarjun merged commit f95bf27 into rancher:main Dec 30, 2024
1 check passed
@sunilarjun sunilarjun deleted the sync-community branch December 30, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants