Don't fail requests if we can't update clusterAuthToken.lastUsedAt #32
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatseykanets
force-pushed
the
lastUsedAt-updates
branch
from
c3a4bc3 to
a6e3a79
Compare
pmatseykanets
force-pushed
the
lastUsedAt-updates
branch
from
a6e3a79 to
7ea87ac
Compare
pmatseykanets
changed the title
JonCrowther
reviewed
Feb 6, 2025
| @@ -135,31 +133,31 @@ func (h *KubeAPIHandlers) v1getAndVerifyUser(accessKey, secretKey string) (*type | |||
|
|
|||
| if refresh.Add(refreshPeriod).Before(now) { | |||
| clusterUserAttribute.NeedsRefresh = true | |||
| shouldUpdate = true | |||
| if _, err := h.clusterUserAttribute.Update(clusterUserAttribute); err != nil { | |||
There was a problem hiding this comment.
Previously we weren't updating the clusterUserAttribute. Why are we adding this here?
There was a problem hiding this comment.
We accidentally stopped updating it in #28 and now we do again as we should.
pmatseykanets
commented
Feb 6, 2025
| _, err = h.clusterAuthTokens.Update(clusterAuthToken) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error updating clusterAuthToken %s: %w", clusterAuthToken.Name, err) | ||
| if _, err = h.clusterAuthTokens.Update(clusterAuthToken); err != nil { |
There was a problem hiding this comment.
In the future we may want to migrate to wrangler and use patch here instead as we do for the local cluster.
JonCrowther
approved these changes
Feb 6, 2025
| @@ -135,31 +133,31 @@ func (h *KubeAPIHandlers) v1getAndVerifyUser(accessKey, secretKey string) (*type | |||
|
|
|||
| if refresh.Add(refreshPeriod).Before(now) { | |||
| clusterUserAttribute.NeedsRefresh = true | |||
| shouldUpdate = true | |||
| if _, err := h.clusterUserAttribute.Update(clusterUserAttribute); err != nil { | |||
crobby
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: rancher/rancher#48986
clusterAuthToken.lastUsedAt(don't fail or retry).Ideally we want to migrate
cluster.cattle.ioto wrangler and usepatchforlastUsedAtupdates instead as we do for the counterpart tokens in the local cluster.