Update go version and packages for CVE-2023-44487 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
approved these changes
Jan 25, 2024
macedogm
requested changes
Jan 25, 2024
There was a problem hiding this comment.
I would recommend to bump Go to 1.21 directly, plus also bump some Go dependencies:
github.com/containerd/containerdto1.6.26or highergithub.com/cyphar/filepath-securejointo0.2.4or highergithub.com/docker/dockerto20.10.27or highergo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpto0.44.0or highergolang.org/x/cryptoto0.17.0or higherk8s.io/kubernetesto1.27.10and allk8s.io/*deps to match the same version
|
@macedogm Do we want to lump all of these changes in this PR? Or create a subsequent PR for proposed additional version bumps? |
Both way works for me. Feel free to do the way that is the best for you. |
pjbgf
approved these changes
Jan 25, 2024
|
We could just merge this PR and #18. So that the bumps can be managed automatically. |
macedogm
approved these changes
Jan 25, 2024
pmatseykanets
changed the title
pmatseykanets
added a commit
that referenced
this pull request
Feb 22, 2024
* Update to Go 1.21 * Update deps for k8s 1.27 * Update rancher and norman dependencies * Bump x/crypto to v0.17.0 * Bump go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.44.0 Ref: #20 (review), rancher/rancher#43318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#43318, #19