Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi node in shared mode #269

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

galal-hussein
Copy link
Collaborator

@galal-hussein galal-hussein commented Feb 24, 2025

The PR adds the following:

  • Converting the shared agent deployment to deamonset so that it can be scheduled on all nodes of the host cluster

  • Using the cluster.Spec.NodeSelector to only schedule the pods of the agent daemonset to specific nodes selected by the user

  • Using leader election for controllers running by the k3k-kubelet

  • Refactoring the PV/PVC support by:

    • for each pod that consumes a pvc, we create a fake PV (pseudoPV) in the virtual cluster to simulate persistent volume, this will enable the pod to be picked up (scheduled) by the virtual-kubelet and then created on the host cluster
  • [EPIC]Support multiple nodes (agents) in shared mode #167

Signed-off-by: galal-hussein <[email protected]>
Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, maybe we need to go through all the logging part to define a coding style.

@galal-hussein
Copy link
Collaborator Author

A couple of small comments, maybe we need to go through all the logging part to define a coding style.

Will fix, yeah I think the logging should be standardized throughout the repo.

Signed-off-by: galal-hussein <[email protected]>
Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, great work 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants