-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multi node in shared mode #269
Conversation
Signed-off-by: galal-hussein <[email protected]>
5a89552
to
3219e31
Compare
Signed-off-by: galal-hussein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments, maybe we need to go through all the logging part to define a coding style.
Will fix, yeah I think the logging should be standardized throughout the repo. |
Signed-off-by: galal-hussein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, great work 👏
The PR adds the following:
Converting the shared agent deployment to deamonset so that it can be scheduled on all nodes of the host cluster
Using the cluster.Spec.NodeSelector to only schedule the pods of the agent daemonset to specific nodes selected by the user
Using leader election for controllers running by the k3k-kubelet
Refactoring the PV/PVC support by:
[EPIC]Support multiple nodes (agents) in shared mode #167