Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify handling of GitRepo status resources #13244

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Jan 30, 2025

Summary

Change how the GitRepo status info is obtained and processed, by consuming the new fields exposed by Fleet.

Occurred changes and/or fixed issues

Fixes #13243

Technical notes summary

This PR changes (again, see #12896) the way that bundles state is processed, by iterating over the list of bundles, for simplicity.
Also:

  • It uses the new PerClusterResourceCounts status field
  • Uses the new format for Resources.perClusterState in order to build the GitRepo's resource table, getting rid of BundleDeployments altogether.

Areas or cases that should be tested

Areas which could experience regressions

There is a small regression in the Resources table for GitRepos, since the info backing the Age column is no longer available. However, this field was often blank as it's not always available.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aruiz14 aruiz14 added this to the v2.11.1 milestone Jan 30, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.11.1, v2.11.0 Jan 30, 2025
@aruiz14 aruiz14 force-pushed the fleet-resources-rework branch from 0c7cec3 to 8de803e Compare January 31, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify handling of GitRepo status resources
1 participant