Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.9] fix wf catalog build on creators + creators version bump #13003

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[release-2.9] fix wf catalog build on creators + creators version bump #13003

merged 2 commits into from
Jan 7, 2025
+5 −2

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jan 7, 2025 •
edited
Loading

Summary

Fixes #12993
Fixes #12988

Occurred changes and/or fixed issues

  • fix workflow for catalog build on creators package by adding missing tagged_release input
  • bump creators version
  • fix dependencies resolutions because of node package updates upstream that are incompatible with node 16

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.6 milestone Jan 7, 2025
@aalves08 aalves08 self-assigned this Jan 7, 2025
@aalves08 aalves08 mentioned this pull request Jan 7, 2025
Closed
7 tasks
cnotv
cnotv approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 5800169 into rancher:release-2.9 Jan 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv cnotv approved these changes

@richard-cox richard-cox Awaiting requested review from richard-cox

@jordojordo jordojordo Awaiting requested review from jordojordo

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
v2.9.6
Development

Successfully merging this pull request may close these issues.
2 participants
@aalves08 @cnotv