Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: fleet dashboard tests #12983

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Jan 6, 2025

Summary

Fixes #rancher/qa-tasks#1360

This PR reenables existing and adds new Fleet Dashboard view tests

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.11.0 milestone Jan 6, 2025
@yonasberhe23 yonasberhe23 self-assigned this Jan 6, 2025
@yonasberhe23 yonasberhe23 force-pushed the fleet_dashboard_tests branch 4 times, most recently from db5d172 to c753297 Compare January 7, 2025 00:55
@yonasberhe23 yonasberhe23 requested a review from izaac January 7, 2025 17:15
@yonasberhe23 yonasberhe23 force-pushed the fleet_dashboard_tests branch 4 times, most recently from 0487029 to fee0035 Compare January 8, 2025 20:31
@yonasberhe23 yonasberhe23 force-pushed the fleet_dashboard_tests branch from fee0035 to 3c8e3b1 Compare January 8, 2025 20:37

// row.get('.bg-success[data-testid="clusters-ready"]', LONG_TIMEOUT_OPT).should('exist');
// row.get('.bg-success[data-testid="clusters-ready"] span').should('have.text', '1/1');
row.get('.bg-success[data-testid="clusters-ready"]', LONG_TIMEOUT_OPT).should('exist');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it's not possible to avoid this row.get in this case is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct in this case .get is a method in cypress/e2e/po/components/list-row.po.ts and accepts selector and options as arguments. Instead of the cy.get() command

@yonasberhe23 yonasberhe23 merged commit 374ca33 into rancher:master Jan 9, 2025
32 checks passed
@yonasberhe23 yonasberhe23 deleted the fleet_dashboard_tests branch January 14, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants