Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10.2] Fix Node Scheduling / Node Name option in Workloads page #12964

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[2.10.2] Fix Node Scheduling / Node Name option in Workloads page #12964

merged 1 commit into from
Jan 7, 2025

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 2, 2025 •
edited
Loading

Summary

Fixes #12963

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf added this to the v2.10.2 milestone Jan 2, 2025
@torchiaf torchiaf requested a review from a110605 January 2, 2025 11:23
@torchiaf torchiaf force-pushed the backport-2.10-12962 branch from f71958c to 477ebe1 Compare January 2, 2025 11:25
@torchiaf
[backport 12962]
b1cc2c0 
- Fix Node Selector value update
- Implement NodeScheduling.test

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf force-pushed the backport-2.10-12962 branch from 477ebe1 to b1cc2c0 Compare January 7, 2025 09:56
cnotv
cnotv approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit 4c38b9f into rancher:release-2.10 Jan 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnotv cnotv cnotv approved these changes

@a110605 a110605 Awaiting requested review from a110605

Assignees

@torchiaf torchiaf

Labels
None yet
Projects
None yet
Milestone
v2.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@torchiaf @cnotv