Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing types for extensions #12952

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add missing types for extensions #12952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb709c0
add mising types for extensions
aalves08 Dec 26, 2024
81c171a
add missing type
aalves08 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion shell/core/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,16 @@ export interface ProductOptions {
*/
to?: PluginRouteRecordRaw;

/**
* Alternative to the icon property. Uses require
*/
svg?: Function;

/**
* Product name
*/
name?: string;

/**
* Leaving these here for completeness but I don't think these should be advertised as useable to plugin creators.
*/
Expand Down Expand Up @@ -383,10 +393,15 @@ export interface ConfigureVirtualTypeOptions extends ConfigureTypeOptions {
*/
ifHaveType?: string | RegExp | Object;

/**
* The label that this type should display
*/
label?: string;

/**
* The translation key displayed anywhere this type is referenced
*/
labelKey: string;
labelKey?: string;

/**
* An identifier that should be unique across all types
Expand Down
Loading