Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR gate to ensure checklist has been completed #12931

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Dec 23, 2024

Summary

Add PR gate to ensure checklist has been created

Occurred changes and/or fixed issues

  • There's been PRs that have merged without the required checklist being completed (for instance missing milestones, no reviewers, missing template, dark mode not tested, etc)
  • This PR will ensure all PRs have every checkbox in the pr description checked
  • This does not ensure all required checklists entries are checked, we can update in future if that gap is being abused
  • Gate will check on pr creation and description edit

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.11.0 milestone Dec 23, 2024
@richard-cox richard-cox requested a review from nwmac December 23, 2024 10:25
@richard-cox richard-cox self-assigned this Dec 23, 2024
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Maybe we should beef this up later and check that the checklist is intact - otherwise I can just delete the checklist and it will pass!

@richard-cox richard-cox merged commit 516a6ff into rancher:master Jan 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants