Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dagre-d3 dependency #12927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Dec 20, 2024

Summary

This removes the unused dagre-d3 dependency from Dashboard and Shell.

dagre-d3 was originally introduced via #139; this feature has since been removed, yet the dagre-d3 dependency remained.

This PR should close a high security alert for d3-color: https://github.com/rancher/dashboard/security/dependabot/102

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip
Copy link
Member Author

@aalves08 I would like you to review because you were the original author of the Fleet ForceDirectedTreeChart. While that appears to use both d3 and d3-selection, I don't see any indication that dagre-d3 is required in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants