Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #12895
Performance improvements while keeping the same behavior.
Occurred changes and/or fixed issues
(Changes are logically split into different commits)
clusterID
vs. "clusterLabel" (which normally refers to the management Cluster resource name, while the Fleet Cluster name is usually the same as the "display" name).clusterId
is compound by${namespace}/${name}
of theCluster
resource, making it easier to work with.management
"Cluster" object (clusterLabel
) is only really needed for calculating thedetailLocation
of deployed resouces, as they will link to the Explorer, which uses the management clusters' names.clusterResourceStatus
, which is always combined with afind
byclusterLabel
(nowclusterId
).Technical notes summary
Above changes were driven by capturing and analyzing Performance traces with the Chrome Dev Tools, on a local Rancher installation where many sample workloads were installed.
See a summary of CPU usage over 30s of loading the CD dashboard:
Areas or cases that should be tested
Areas which could experience regressions
These changes aim for improving performance while not introducing any changes to the information being displayed.
I've performed several tests using a local UI build and couldn't find any difference, but I may have missed something.
Checklist