Fix yaml editor styling #11823
Merged
Fix yaml editor styling #11823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
force-pushed
the
vue3-fix-codemirror-style
branch
2 times, most recently
from
3119ae2 to
ebfbecd
Compare
mantis-toboggan-md
force-pushed
the
vue3-fix-codemirror-style
branch
from
ebfbecd to
62c17af
Compare
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* fix codemirror styling * fix keyvalue codemirror style * fix codemirror json annotation display * fix fold gutters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11701
Occurred changes and/or fixed issues
This PR fixes Codemirror styling (used in yaml editor and a couple other places). There were two main issues: this new library introduced new styles, which can be overwritten via prop (added here). The new library also had a hardcoded font value the old did not.
I also noticed some Codemirror elements are arranged differently. I left all this alone, I wouldn't consider it a bug and it looks better now anyway:
(old)
(new)
The resize nullpx nullpx message reported in #11701 is a known issue with the library rennzhang/codemirror-editor-vue3#54
Technical notes summary
Areas or cases that should be tested
'View as Yaml' and 'Edit as Yaml' pages
Create/edit a configmap with json values
Detail view of a resource with json annotations
Screenshot/Video
(old)
(new)
(old)
(new)
(old)
(new)
Checklist