Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing slack messaging workflow #11660

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Aug 19, 2024

Summary

Fixes #11482

Occurred changes and/or fixed issues

  • Add steps for Slack messaging via POST curl to Slack workflow webhook

Technical notes summary

Based on the work done in https://github.com/rancher/dashboard/pull/11662/files since from forks we cannot "use" secrets. Currently, the workflow setup to send a message only to me but that can be changed to communicate to a channel or any other desired Slack output. Also, this will generate a message per combo of system + extension. If we have 2.9 and 2.10, with 5 extensions tests, we will get 10 messages in the future, as it's configured.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Screenshot 2024-08-19 at 15 29 20

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.10.0 milestone Aug 19, 2024
@aalves08 aalves08 self-assigned this Aug 19, 2024
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, otherwise lgtm - Would be nice to get the messages down or possibly shoved into a thread

@aalves08 aalves08 merged commit dc7784a into rancher:master Aug 19, 2024
30 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
* testing slack messaging workflow

* comment other workflows2

* comment other workflows

* fix issue wf

* add missing webhook url

* adjust wf

* adjust wf

* adjust wf

* adjust wf

* revert triggers on other workflows + add message to slack for extensions compatibility tests

* remove undesired file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions: Vue 3 extension validation and compatibility
2 participants