-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing slack messaging workflow #11660
Merged
aalves08
merged 11 commits into
rancher:master
from
aalves08:slack-msg-extensions-compat-wf
Aug 19, 2024
Merged
testing slack messaging workflow #11660
aalves08
merged 11 commits into
rancher:master
from
aalves08:slack-msg-extensions-compat-wf
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jordojordo
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes, otherwise lgtm - Would be nice to get the messages down or possibly shoved into a thread
jordojordo
approved these changes
Aug 19, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* testing slack messaging workflow * comment other workflows2 * comment other workflows * fix issue wf * add missing webhook url * adjust wf * adjust wf * adjust wf * adjust wf * revert triggers on other workflows + add message to slack for extensions compatibility tests * remove undesired file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11482
Occurred changes and/or fixed issues
Technical notes summary
Based on the work done in https://github.com/rancher/dashboard/pull/11662/files since from forks we cannot "use" secrets. Currently, the workflow setup to send a message only to me but that can be changed to communicate to a channel or any other desired Slack output. Also, this will generate a message per combo of system + extension. If we have 2.9 and 2.10, with 5 extensions tests, we will get 10 messages in the future, as it's configured.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist