[2.9] Bump version of gh artifact actions

[richard-cox]

Summary

• bump deprecated gh action artifact v3 to v4
• similar to Bump actions/upload-artifact from 3 to 4 #13102 and Bump actions/checkout from 2 to 4 #13100

Checklist

• The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
• The PR has a Milestone
• The PR template has been filled out
• The PR has been self reviewed
• The PR has a reviewer assigned
• The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
• The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

[rak-phillip]

I think this looks good.

If I understand, the intent of this change is to take a more targeted approach compared to what was done in the linked PRs? I still see instances of actions/checkout@v2 & actions/checkout@v3 referenced throughout different workflows:

[richard-cox]

Accidental, was fixing the specific one's that were broken. Some of the others need doing (like build) for later anyway

[rak-phillip]

LGTM - the priority is to unblock gates for the release-2.9 branch.

[rak-phillip]

All gates pass, merging.