Merge pull request #13304 from richard-cox/fix-action-upload-artifact

[2.9] Bump version of gh artifact actions
rancher · Feb 6, 2025 · dd03962 · dd03962
2 parents e1a6686 + 65f292a
commit dd03962
Show file tree

Hide file tree

Showing 12 changed files with 54 additions and 53 deletions.
diff --git a/.github/workflows/add-issue-labels.yaml b/.github/workflows/add-issue-labels.yaml
@@ -9,7 +9,7 @@ jobs:
     permissions:
       issues: write
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Use Node.js
       uses: actions/setup-node@v1
       with:

diff --git a/.github/workflows/build-and-upload.yaml b/.github/workflows/build-and-upload.yaml
@@ -22,7 +22,7 @@ jobs:
     name: Build & Upload Hosted
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -69,7 +69,7 @@ jobs:
     name: Build & Upload Embedded
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 

diff --git a/.github/workflows/build-extension-charts.yml b/.github/workflows/build-extension-charts.yml
@@ -108,7 +108,7 @@ jobs:
 
       - name: Upload charts artifact
         if: github.ref_type == 'tag' || (github.ref == 'refs/heads/main' && github.event_name != 'pull_request') || inputs.is_test == 'true'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: charts
           path: tmp
@@ -135,7 +135,7 @@ jobs:
           git config user.email 'github-actions[bot]@users.noreply.github.com'
 
       - name: Download build artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: charts
 

diff --git a/.github/workflows/build-test.yaml b/.github/workflows/build-test.yaml
@@ -9,7 +9,7 @@ jobs:
   unit-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -19,7 +19,7 @@ jobs:
   i18n:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -29,7 +29,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 

diff --git a/.github/workflows/check-plugins.yaml b/.github/workflows/check-plugins.yaml
@@ -26,7 +26,7 @@ jobs:
         shell: bash
 
       - name: Upload files
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: test

diff --git a/.github/workflows/docusaurus.yaml b/.github/workflows/docusaurus.yaml
@@ -12,7 +12,7 @@ jobs:
     name: Build
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: 16.x

diff --git a/.github/workflows/pr-gh-project.yaml b/.github/workflows/pr-gh-project.yaml
@@ -12,7 +12,7 @@ jobs:
       id-token: write
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Use Node.js
       uses: actions/setup-node@v1
       with:

diff --git a/.github/workflows/rancher-components.yaml b/.github/workflows/rancher-components.yaml
@@ -10,7 +10,7 @@ jobs:
   validate-build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - uses: actions/setup-node@v3
@@ -26,7 +26,7 @@ jobs:
   validate-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - uses: actions/setup-node@v3

diff --git a/.github/workflows/release-rancher-components.yml b/.github/workflows/release-rancher-components.yml
@@ -12,7 +12,7 @@ jobs:
       contents: read
       packages: write
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
         persist-credentials: false

diff --git a/.github/workflows/release-rancher-desktop.yml b/.github/workflows/release-rancher-desktop.yml
@@ -16,7 +16,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 0
         persist-credentials: false
@@ -30,7 +30,7 @@ jobs:
         ROUTER_BASE="/dashboard" RANCHER_ENV=desktop ./.github/workflows/scripts/build-dashboard.sh
 
     - name: Upload Build
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         path: ${{ env.RELEASE_DIR}}/${{ env.ARTIFACT_NAME }}*
         name: ${{ env.ARTIFACT_NAME }}
@@ -40,12 +40,12 @@ jobs:
     runs-on: ubuntu-latest
     needs: build
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
       with:
         fetch-depth: 1
         persist-credentials: false
     - name: Download build
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
       with:
         name: ${{ env.ARTIFACT_NAME }}
         path: build

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -37,7 +37,7 @@ jobs:
     if: "!contains( github.event.pull_request.labels.*.name, 'ci/skip-e2e')"
     runs-on: ubuntu-latest
     steps:
-     - uses: actions/checkout@v3
+     - uses: actions/checkout@v4
        with:
         fetch-depth: 1
      - name: Setup env
@@ -83,7 +83,7 @@ jobs:
         ]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - name: Setup env
@@ -131,7 +131,7 @@ jobs:
           TEST_USERNAME: ${{ matrix.role.username }}
 
       - name: Upload screenshots
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: ${{ failure() }}
         with:
           name: ${{github.run_number}}-${{github.run_attempt}}-screenshots-${{ matrix.role.tag }}+${{ matrix.features[0] }}
@@ -140,7 +140,7 @@ jobs:
   unit-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -154,15 +154,15 @@ jobs:
           cp -r coverage/unit/ coverage-artifacts/coverage/unit/
 
       - name: Upload coverage
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{github.run_number}}-${{github.run_attempt}}-coverage
           path: coverage-artifacts/**/*
 
   i18n:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -172,7 +172,7 @@ jobs:
   check-i18n:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - uses: actions/setup-node@v3
@@ -190,7 +190,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
@@ -200,7 +200,7 @@ jobs:
   check-e2e-tags:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
       - uses: actions/setup-node@v3

diff --git a/cypress/e2e/tests/pages/fleet/gitrepo.spec.ts b/cypress/e2e/tests/pages/fleet/gitrepo.spec.ts
@@ -144,40 +144,41 @@ describe('Git Repo', { testIsolation: 'off', tags: ['@fleet', '@adminUser'] }, (
       ;
     });
 
-    it('check table headers are available in list and details view', { tags: ['@vai', '@adminUser'] }, function() {
-      const workspace = 'fleet-default';
+    // Enabling again in https://github.com/rancher/dashboard/pull/13305
+    // it('check table headers are available in list and details view', { tags: ['@vai', '@adminUser'] }, function() {
+    //   const workspace = 'fleet-default';
 
-      // go to fleet gitrepo
-      listPage.goTo();
-      listPage.waitForPage();
-      headerPo.selectWorkspace(workspace);
+    //   // go to fleet gitrepo
+    //   listPage.goTo();
+    //   listPage.waitForPage();
+    //   headerPo.selectWorkspace(workspace);
 
-      // check table headers
-      const expectedHeadersListView = ['State', 'Name', 'Repo', 'Target', 'Clusters Ready', 'Resources', 'Age'];
+    //   // check table headers
+    //   const expectedHeadersListView = ['State', 'Name', 'Repo', 'Target', 'Clusters Ready', 'Resources', 'Age'];
 
-      listPage.repoList().resourceTable().sortableTable().tableHeaderRow()
-        .within('.table-header-container .content')
-        .each((el, i) => {
-          expect(el.text().trim()).to.eq(expectedHeadersListView[i]);
-        });
+    //   listPage.repoList().resourceTable().sortableTable().tableHeaderRow()
+    //     .within('.table-header-container .content')
+    //     .each((el, i) => {
+    //       expect(el.text().trim()).to.eq(expectedHeadersListView[i]);
+    //     });
 
-      // go to fleet gitrepo details
-      listPage.repoList().details(this.gitRepo, 2).find('a').click();
+    //   // go to fleet gitrepo details
+    //   listPage.repoList().details(this.gitRepo, 2).find('a').click();
 
-      const gitRepoDetails = new FleetGitRepoDetailsPo(workspace, this.gitRepo);
+    //   const gitRepoDetails = new FleetGitRepoDetailsPo(workspace, this.gitRepo);
 
-      gitRepoDetails.waitForPage(null, 'bundles');
+    //   gitRepoDetails.waitForPage(null, 'bundles');
 
-      // check table headers
-      const expectedHeadersDetailsView = ['State', 'Name', 'Deployments', 'Last Updated', 'Date'];
+    //   // check table headers
+    //   const expectedHeadersDetailsView = ['State', 'Name', 'Deployments', 'Last Updated', 'Date'];
 
-      gitRepoDetails.bundlesTab().list().resourceTable().sortableTable()
-        .tableHeaderRow()
-        .within('.table-header-container .content')
-        .each((el, i) => {
-          expect(el.text().trim()).to.eq(expectedHeadersDetailsView[i]);
-        });
-    });
+    //   gitRepoDetails.bundlesTab().list().resourceTable().sortableTable()
+    //     .tableHeaderRow()
+    //     .within('.table-header-container .content')
+    //     .each((el, i) => {
+    //       expect(el.text().trim()).to.eq(expectedHeadersDetailsView[i]);
+    //     });
+    // });
 
     it('check all tabs are available in the details view', function() {
       // testing https://github.com/rancher/dashboard/issues/11155