fix(Networking): fix unable to edit Host Aliases configuration of a w…

…orkload pod
rancher · Jan 7, 2025 · f409dba · f409dba
1 parent 7632c51
commit f409dba
Showing 1 changed file with 16 additions and 7 deletions.
diff --git a/shell/components/form/Networking.vue b/shell/components/form/Networking.vue
@@ -29,7 +29,7 @@ export default {
 
   data() {
     const t = this.$store.getters['i18n/t'];
-    const hostAliases = (this.value.hostAliases || []).map((entry) => {
+    const tmpHostAliases = (this.value.hostAliases || []).map((entry) => {
       return {
         ip:        entry.ip,
         hostnames: entry.hostnames.join(', ')
@@ -41,12 +41,12 @@ export default {
     const out = {
       dnsPolicy:   this.value.dnsPolicy || 'ClusterFirst',
       networkMode: this.value.hostNetwork ? { label: t('workload.networking.networkMode.options.hostNetwork'), value: true } : { label: t('workload.networking.networkMode.options.normal'), value: false },
-      hostAliases,
       nameservers,
       searches,
       hostname,
       subdomain,
-      options
+      options,
+      tmpHostAliases
     };
 
     return out;
@@ -81,6 +81,15 @@ export default {
       ];
     },
 
+    hostAliases() {
+      return (this.value.hostAliases || []).map((entry) => {
+        return {
+          ip:        entry.ip,
+          hostnames: entry.hostnames?.join(', ') ?? ''
+        };
+      });
+    },
+
     ...mapGetters({ t: 'i18n/t' })
   },
 
@@ -113,12 +122,12 @@ export default {
 
   methods: {
     updateHostAliases(neu) {
-      this.hostAliases = neu.map((entry) => {
+      this.tmpHostAliases = neu.map((entry) => {
         const ip = entry.ip.trim();
         const hostnames = entry.hostnames.trim().split(/[\s,]+/).filter((x) => !!x);
 
         return { ip, hostnames };
-      }).filter((entry) => entry.ip && entry.hostnames.length);
+      });
       this.update();
     },
 
@@ -134,7 +143,7 @@ export default {
         dnsConfig,
         dnsPolicy:   this.dnsPolicy,
         hostname:    this.hostname,
-        hostAliases: this.hostAliases,
+        hostAliases: this.tmpHostAliases,
         subdomain:   this.subdomain,
         hostNetwork: this.networkMode.value
       };
@@ -248,7 +257,7 @@ export default {
       <div class="col span-12">
         <KeyValue
           key="hostAliases"
-          v-model:value="hostAliases"
+          :value="hostAliases"
           :mode="mode"
           :title="t('workload.networking.hostAliases.label')"
           :protip="t('workload.networking.hostAliases.tip')"