Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make etcd snapshot location configurable #264

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Feb 13, 2024

If S3 storage is specified and used, set the etcdSnapshotDir to S3 folder and use local directory when local storage is utilized

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

If S3 storage is specified and used, set the etcdSnapshotDir to S3 folder while
use local directory when local storage is utilized

Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 furkatgofurov7 added the kind/refactor Denotes a change that is a refactor label Feb 13, 2024
@furkatgofurov7 furkatgofurov7 self-assigned this Feb 13, 2024
@richardcase richardcase merged commit c3fa4eb into rancher:main Feb 15, 2024
7 checks passed
@furkatgofurov7 furkatgofurov7 deleted the backup branch February 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Denotes a change that is a refactor
Development

Successfully merging this pull request may close these issues.

3 participants