WIP [v7.x] Make BRO compliant with security best practices #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbiers
force-pushed
the
security-best-practices
branch
from
006b34a to
3d9f24a
Compare
jbiers
changed the title
jbiers
force-pushed
the
security-best-practices
branch
from
6584af3 to
6455b95
Compare
jbiers
force-pushed
the
security-best-practices
branch
from
6455b95 to
5bae745
Compare
jbiers
changed the title
jbiers
changed the title
jbiers
changed the title
|
I've opened an initial PR to make sure the BRO chart is compliant with the best practices as best as possible. Notably, BRO creates files locally while building the backups, so setting readOnlyRootFilesystem to true breaks the application and is therefore not possible. For those reasons I chose to make the runAsUser setting optional, having a warning about security in the values file. It would be good if we could get a code review from the security team on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#767