Cleanup dapper and code #626
Conversation
alexandreLamarre
force-pushed
the
cleanup
branch
from
450e8fb to
615ce2e
Compare
alexandreLamarre
force-pushed
the
cleanup
branch
2 times, most recently
from
74f21a3 to
010f271
Compare
alexandreLamarre
force-pushed
the
cleanup
branch
2 times, most recently
from
bbb058d to
26859b8
Compare
There was a problem hiding this comment.
Eventually this file should be generated automatically... For now, I used helm template on only the rancher resource set template to create this.
Ideally this file generation should fit inside the go generate step, and so should the chart generation IMO, which I can follow up with in a separate PR
| "sync" | ||
| ) | ||
|
|
||
| type Initializer struct { |
There was a problem hiding this comment.
Not sure I'm following everything going on here - but I think I get the gist.
A new mechanism to control global state related to controller config/settings.
There was a problem hiding this comment.
TLDR; its a synchronization primitive wrapper that ensures its closure is only set once, and anyone that shows interest in what it encapsulates must wait for it to be set. It was used a lot in opni
There was a problem hiding this comment.
err actually sed still an issue for the helm command:
+ sed -i -e 's/^version:.*/version: 26859b8/' -e 's/^appVersion:.*/appVersion: 26859b8/' -e 's/catalog.cattle.io\/upstream-version:.*/catalog.cattle.io\/upstream-version: 26859b8/' build/charts/rancher-backup/Chart.yaml
sed: -e: No such file or directory
make: *** [package-helm] Error 1
Current PR change set fixes this, GG!
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
exclude vscode specific configurations Signed-off-by: Alexandre Lamarre <[email protected]>
Part of : #561