Adjust Renovate Rules #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alexandreLamarre
requested changes
May 8, 2024
There was a problem hiding this comment.
Looks like a better way to do this would be to use https://docs.renovatebot.com/configuration-options/#ignoredeps.
I think potentially we would want to ignore bumps to those in any branch of backup-restore-operator, since it likely requires manual work or aggressive updates that force support out of a given k8s range
An example from another big open source repo is:
|
@alexandreLamarre - thanks for the input here, that does seem like it will make more sense! Updated PR to use that. |
alexandreLamarre
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few Rancher modules as global ignores across all branches. This will hopefully prevent the renovate PRs from causing as many breaking changes. Often when those modules are updated they need code generation to run too which is not currently part of Renovate tasks.
This PR attempts to address the way that the 3.x and 4.x branch must keep K8S support to match their rancher versions. Essentially when the auto bump affects these packages (which are not versioned) the result is bumping peers (k8s.ioitems) that these branches of BRO cannot increase without causing breaking changes.Example Open PRs Causing issues:
#461
#462
And here's an example of what it takes to get these types of PRs mergable:
#458
#459