Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in local ref for CI actions #457

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented May 1, 2024

  • embedded job did not point to the correct path
  • embedded job was not callable without workflow_call

Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review May 1, 2024 20:45
@@ -10,7 +10,9 @@ permissions:

jobs:
ci:
uses: rancher/backup-restore/.github/workflows/ci.yaml@release/v5.0
uses: rancher/backup-restore-operator/.github/workflows/ci.yaml@release/v5.0
permissions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please remove the space after the :

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad for merging if the checks in 455 failed. Please remove the extra space. Looks fine otherwise.

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpromislow ericpromislow merged commit 070786a into release/v5.0 May 1, 2024
3 checks passed
@alexandreLamarre alexandreLamarre deleted the gha-typo branch May 13, 2024 14:26
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants