-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for getting growth estimates #1778
Added support for getting growth estimates #1778
Conversation
@ValueRaider all data from page analysis are available at quote_summory module earningsTrend |
@bot-unit I saved all the other data on the analysis page. No point discarding data for which we have already paid the tax of retrieving |
The question is to parse with pandas html page or just json answer from api |
Benchmark comparison with |
Ok. But any way, we should keep scraping code too. Yahoo can change or block API in future. I will add API calls to this code and do some benchmarks. |
@coskos-ops Just looking at code there's probably opportunity to format types etc. Correct me if wrong. See |
Saved additional data available on analysis page The previous commit only saved the growth estimates. This is a bit of a waste since we are getting all the data on the page anyway. Might as well save all of it. Modified test cases to be consistent with other ones
395ef6e
to
317a6d0
Compare
Changed target to branch |
Added support for getting growth estimates. Some people wanted this feature as seen in #1280 and #575. Added basic scraping logic for the analysis section.
Only growth estimates are added for now but it can easily be extended to support some of the other data in that section.
Added a test case to check if the growth estimates are properly being retrieved.
Edit: Updated the PR to save all the other information available on the analysis page. The code already scrapes all of the data on the analysis page so it is wasteful to discard all but one entry