Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON deserialize error that TrackLink::id could be null #487

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

ramsayleung
Copy link
Owner

Description

Fix JSON deserialize error that TrackLink::id could be null, and add the missing type and uri field for TrackLink based on the updated Spotify document: https://developer.spotify.com/documentation/web-api/concepts/track-relinking

Motivation and Context

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • All CI jobs pass
  • newly added unit test: test_null_id_in_track_link pass

Is this change properly documented?

Yes.

@ramsayleung ramsayleung merged commit c38948f into master Aug 5, 2024
7 checks passed
@ramsayleung ramsayleung deleted the ramsay/fix-tracklink-id-null branch August 5, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant