Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] the suspicious use of OpenOptions::create() without an explicit OpenOptions::truncate(). #468

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Mar 24, 2024

Description

Rust 1.77 introduces a new cargo clippy lint rule for the suspicious use of OpenOptions::create() without an explicit OpenOptions::truncate(), which failed the cargo clipy CI task

Motivation and Context

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • cargo clippy -p rspotify -p rspotify-http -p rspotify-model -p rspotify-macros --no-default-features --features=rspotify/cli,rspotify/env-file,rspotify/client-ureq,rspotify/ureq-rustls-tls,rspotify-http/client-ureq,rspotify-http/ureq-rustls-tls --all-targets -- -D warnings: passed
  • All CI tasks passed

Is this change properly documented?

It's unnecessary.

@ramsayleung ramsayleung merged commit 63c3bba into master Mar 24, 2024
6 checks passed
@ramsayleung ramsayleung deleted the ramsay/fix-suspicious_open_options branch March 24, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant