Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix the filter of GitHub Action on event #463

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ramsayleung
Copy link
Owner

Description

Fix the filter of GitHub Action on event

Motivation and Context

The on section specifies the events that trigger workflow, what I expect is the workflow only get triggered when new tag name v* is created(e.g. new version is published).

However, the current configuration will trigger the workflow not only when a new tag is created but also when any other type of creation event occurs(such as creating a new branch)

Fixing it by enclosing the tag pattern 'v*' in single quotes, it should explicitly specfy that the workflow should trigger only when a new tg matching that pattern is created.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

This PR shoudn't trigger the Publish Create workflow

Is this change properly documented?

It's unnecessary.

@ramsayleung ramsayleung merged commit d2a6571 into master Mar 8, 2024
6 checks passed
@ramsayleung ramsayleung deleted the ramsay/fix-github-action-on-filter branch March 8, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant