Enable proxy detection when using ureq as HTTP client
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsayleung
approved these changes
Jan 29, 2024
|
Thanks for being so expedient. Maybe a little too expedient because I didn't add a changelog yet 😅. You may wish to do that manually FYI. |
|
Can you please consider making a patch release for this? This will allow me to fix the problem in ncspot. Much thanks. |
|
I am on vacation right now, I will release a new version when I am back :)
…On Sun, Feb 4, 2024 at 4:09 PM cyqsimon ***@***.***> wrote:
Can you please consider making a patch release for this? This will allow
me to fix the problem in ncspot. Much thanks.
—
Reply to this email directly, view it on GitHub
<#455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGCSM7FWEVXYYCYWCAKX3YR465LAVCNFSM6AAAAABCO6PIYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGYZDGMRZGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Sorry to ping you again 😅; just a reminder in case you forgot about this. Thanks again. |
|
Thanks for the follow-up, I was working on revert the patch for Spotify Bug before, the v0.13.0 is released: #462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable proxy detection when using
ureqas HTTP client, making it consistent with usingreqwest.Motivation and Context
I found a proxy leak in hrkfdn/ncspot#1384 and traced it back to this crate.
Dependencies
None.
Type of change
Should this count as a bug fix or a new feature? I'm not sure.
How has this been tested?
This is a very minor change that simply calls a function of a dependency. I think it's okay to forgo tests.
Is this change properly documented?
lib.rsdocumentation updated