Remove const Party_ptr&

ramon-bernardo · Sep 1, 2024 · 0b8f40d · 0b8f40d
1 parent 6e8fe92
commit 0b8f40d
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/src/events.cpp b/src/events.cpp
@@ -380,7 +380,7 @@ void Events::eventCreatureOnUpdateStorage(Creature* creature, uint32_t key, std:
 }
 
 // Party
-bool Events::eventPartyOnJoin(const Party_ptr& party, Player* player)
+bool Events::eventPartyOnJoin(Party_ptr party, Player* player)
 {
 	// Party:onJoin(player) or Party.onJoin(self, player)
 	if (info.partyOnJoin == -1) {
@@ -407,7 +407,7 @@ bool Events::eventPartyOnJoin(const Party_ptr& party, Player* player)
 	return scriptInterface.callFunction(2);
 }
 
-bool Events::eventPartyOnLeave(const Party_ptr& party, Player* player)
+bool Events::eventPartyOnLeave(Party_ptr party, Player* player)
 {
 	// Party:onLeave(player) or Party.onLeave(self, player)
 	if (info.partyOnLeave == -1) {
@@ -458,7 +458,7 @@ bool Events::eventPartyOnDisband(Party_ptr party)
 	return scriptInterface.callFunction(1);
 }
 
-bool Events::eventPartyOnInvite(const Party_ptr& party, Player* player)
+bool Events::eventPartyOnInvite(Party_ptr party, Player* player)
 {
 	// Party:onInvite(player) or Party.onInvite(self, player)
 	if (info.partyOnInvite == -1) {
@@ -485,7 +485,7 @@ bool Events::eventPartyOnInvite(const Party_ptr& party, Player* player)
 	return scriptInterface.callFunction(2);
 }
 
-bool Events::eventPartyOnRevokeInvitation(const Party_ptr& party, Player* player)
+bool Events::eventPartyOnRevokeInvitation(Party_ptr party, Player* player)
 {
 	// Party:onRevokeInvitation(player) or Party.onRevokeInvitation(self, player)
 	if (info.partyOnRevokeInvitation == -1) {
@@ -512,7 +512,7 @@ bool Events::eventPartyOnRevokeInvitation(const Party_ptr& party, Player* player
 	return scriptInterface.callFunction(2);
 }
 
-bool Events::eventPartyOnPassLeadership(const Party_ptr& party, Player* player)
+bool Events::eventPartyOnPassLeadership(Party_ptr party, Player* player)
 {
 	// Party:onPassLeadership(player) or Party.onPassLeadership(self, player)
 	if (info.partyOnPassLeadership == -1) {
@@ -539,7 +539,7 @@ bool Events::eventPartyOnPassLeadership(const Party_ptr& party, Player* player)
 	return scriptInterface.callFunction(2);
 }
 
-void Events::eventPartyOnShareExperience(const Party_ptr& party, uint64_t& exp)
+void Events::eventPartyOnShareExperience(Party_ptr party, uint64_t& exp)
 {
 	// Party:onShareExperience(exp) or Party.onShareExperience(self, exp)
 	if (info.partyOnShareExperience == -1) {

diff --git a/src/events.h b/src/events.h
@@ -91,13 +91,13 @@ class Events
 	                                  std::optional<int32_t> oldValue, bool isSpawn);
 
 	// Party
-	bool eventPartyOnJoin(const Party_ptr& party, Player* player);
-	bool eventPartyOnLeave(const Party_ptr& party, Player* player);
+	bool eventPartyOnJoin(Party_ptr party, Player* player);
+	bool eventPartyOnLeave(Party_ptr party, Player* player);
 	bool eventPartyOnDisband(Party_ptr party);
-	void eventPartyOnShareExperience(const Party_ptr& party, uint64_t& exp);
-	bool eventPartyOnInvite(const Party_ptr& party, Player* player);
-	bool eventPartyOnRevokeInvitation(const Party_ptr& party, Player* player);
-	bool eventPartyOnPassLeadership(const Party_ptr& party, Player* player);
+	void eventPartyOnShareExperience(Party_ptr party, uint64_t& exp);
+	bool eventPartyOnInvite(Party_ptr party, Player* player);
+	bool eventPartyOnRevokeInvitation(Party_ptr party, Player* player);
+	bool eventPartyOnPassLeadership(Party_ptr party, Player* player);
 
 	// Player
 	bool eventPlayerOnBrowseField(Player* player, const Position& position);

diff --git a/src/player.cpp b/src/player.cpp
@@ -4230,7 +4230,7 @@ void Player::sendPlayerPartyIcons(Player* player)
 	sendCreatureSkull(player);
 }
 
-bool Player::addPartyInvitation(const Party_ptr& party)
+bool Player::addPartyInvitation(Party_ptr party)
 {
 	auto it = std::find(invitePartyList.begin(), invitePartyList.end(), party);
 	if (it != invitePartyList.end()) {
@@ -4241,7 +4241,7 @@ bool Player::addPartyInvitation(const Party_ptr& party)
 	return true;
 }
 
-void Player::removePartyInvitation(const Party_ptr& party) { invitePartyList.remove(party); }
+void Player::removePartyInvitation(Party_ptr party) { invitePartyList.remove(party); }
 
 void Player::clearPartyInvitations()
 {

diff --git a/src/player.h b/src/player.h
@@ -211,8 +211,8 @@ class Player final : public Creature, public Cylinder
 	bool isInviting(const Player* player) const;
 	bool isPartner(const Player* player) const;
 	void sendPlayerPartyIcons(Player* player);
-	bool addPartyInvitation(const Party_ptr& party);
-	void removePartyInvitation(const Party_ptr& party);
+	bool addPartyInvitation(Party_ptr party);
+	void removePartyInvitation(Party_ptr party);
 	void clearPartyInvitations();
 
 	GuildEmblems_t getGuildEmblem(const Player* player) const;