Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description param to database endpoint #209

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

FlorianWilhelm
Copy link
Contributor

According to the official Notion API there is a new parameter 'description' in the database endpoint for update.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8b8f922) 100.00% compared to head (4f8d023) 100.00%.

❗ Current head 4f8d023 differs from pull request most recent head cc1e82e. Consider uploading reports for the commit cc1e82e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #209   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          294       284   -10     
=========================================
- Hits           294       284   -10     
Files Coverage Δ
notion_client/api_endpoints.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramnes
Copy link
Owner

ramnes commented Oct 19, 2023

Danke Florian! CI is broken but it's mostly unrelated to your PR, so I'll fix this and merge.

@ramnes ramnes merged commit d6b5c1e into ramnes:main Oct 19, 2023
@FlorianWilhelm
Copy link
Contributor Author

Thanks @ramnes!

@FlorianWilhelm FlorianWilhelm deleted the description_param branch October 19, 2023 17:53
@FlorianWilhelm FlorianWilhelm restored the description_param branch October 19, 2023 17:55
@FlorianWilhelm
Copy link
Contributor Author

Hi @ramnes, are you planning on having a minor release to include the update of descriptions? I think it would be pretty nice to have a release with it :-) Thanks.

@ramnes
Copy link
Owner

ramnes commented Nov 4, 2023

@FlorianWilhelm I just released 2.1.0! Thanks for the nudge. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants