fix(eslint-config): fix rules and remove deprecated

rambler-digital-solutions · Jan 19, 2024 · 0b68064 · 0b68064
1 parent 1688e79
commit 0b68064
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/eslint-config/js.js b/packages/eslint-config/js.js
@@ -31,7 +31,6 @@ module.exports = {
     semi: ['error', 'never'],
     'comma-dangle': ['error', 'never'],
     'eol-last': ['error', 'always'],
-    'arrow-parens': ['error', 'always'],
     camelcase: ['error', {ignoreDestructuring: true}],
     eqeqeq: ['error', 'always', {null: 'ignore'}],
     'prefer-const': ['error', {ignoreReadBeforeAssign: true}],
@@ -69,7 +68,7 @@ module.exports = {
     'no-global-assign': 'error',
     'no-extend-native': 'error',
     'no-alert': 'error',
-    'no-console': 'error',
+    'no-console': ['error', {allow: ['warn', 'error']}],
     'no-unsafe-optional-chaining': [
       'error',
       {disallowArithmeticOperators: true}
@@ -114,7 +113,15 @@ module.exports = {
     'no-nested-ternary': 'error',
     'no-unneeded-ternary': 'error',
     'no-param-reassign': 'error',
-    'no-empty-function': 'error',
+    'no-return-assign': 'error',
+    'no-script-url': 'error',
+    'no-useless-computed-key': 'error',
+    'no-useless-concat': 'error',
+    'no-useless-constructor': 'error',
+    'no-var': 'error',
+    'no-void': 'error',
+    'no-with': 'error',
+    'no-empty-function': ['error', {allow: ['arrowFunctions']}],
     'no-constant-condition': [
       'error',
       {

diff --git a/packages/eslint-config/react.js b/packages/eslint-config/react.js
@@ -20,7 +20,9 @@ module.exports = {
     'plugin:react-prefer-function-component/recommended'
   ],
   rules: {
-    'react/prop-types': 0,
+    'react/prop-types': 'off',
+    'react/jsx-pascal-case': 'error',
+    'react/no-multi-comp': 'error',
     'react-hooks/exhaustive-deps': [
       'warn',
       {